r175793 - Patch for debug info of qualified-id types is 'id'

[Fariborz Jahanian]

Author: fjahanian
Date: Thu Feb 21 14:42:11 2013
New Revision: 175793

URL: http://llvm.org/viewvc/llvm-project?rev=175793&view=rev
Log:
Patch for debug info of qualified-id types is 'id'
By Adrian Pranti.

Added:
    cfe/trunk/test/CodeGenObjC/debug-info-id-with-protocol.m
Modified:
    cfe/trunk/lib/CodeGen/CGDebugInfo.cpp

Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CGDebugInfo.cpp?rev=175793&r1=175792&r2=175793&view=diff
==============================================================================
--- cfe/trunk/lib/CodeGen/CGDebugInfo.cpp (original)
+++ cfe/trunk/lib/CodeGen/CGDebugInfo.cpp Thu Feb 21 14:42:11 2013
@@ -530,6 +530,13 @@ llvm::DIType CGDebugInfo::CreateQualifie
 
 llvm::DIType CGDebugInfo::CreateType(const ObjCObjectPointerType *Ty,
                                      llvm::DIFile Unit) {
+
+  // The frontend treats 'id' as a typedef to an ObjCObjectType,
+  // whereas 'id<protocol>' is treated as an ObjCPointerType. For the
+  // debug info, we want to emit 'id' in both cases.
+  if (Ty->isObjCQualifiedIdType())
+      return getOrCreateType(CGM.getContext().getObjCIdType(), Unit);
+
   llvm::DIType DbgTy =
     CreatePointerLikeType(llvm::dwarf::DW_TAG_pointer_type, Ty, 
                           Ty->getPointeeType(), Unit);
@@ -618,7 +625,6 @@ llvm::DIType CGDebugInfo::CreatePointeeT
     return RetTy;
   }
   return getOrCreateType(PointeeTy, Unit);
-
 }
 
 llvm::DIType CGDebugInfo::CreatePointerLikeType(unsigned Tag,
@@ -629,7 +635,7 @@ llvm::DIType CGDebugInfo::CreatePointerL
       Tag == llvm::dwarf::DW_TAG_rvalue_reference_type)
     return DBuilder.createReferenceType(Tag,
                                         CreatePointeeType(PointeeTy, Unit));
-                                    
+
   // Bit size, align and offset of the type.
   // Size is always the size of a pointer. We can't use getTypeSize here
   // because that does not return the correct value for references.

Added: cfe/trunk/test/CodeGenObjC/debug-info-id-with-protocol.m
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGenObjC/debug-info-id-with-protocol.m?rev=175793&view=auto
==============================================================================
--- cfe/trunk/test/CodeGenObjC/debug-info-id-with-protocol.m (added)
+++ cfe/trunk/test/CodeGenObjC/debug-info-id-with-protocol.m Thu Feb 21 14:42:11 2013
@@ -0,0 +1,41 @@
+// RUN: %clang_cc1 -triple x86_64-apple-darwin10 -fobjc-default-synthesize-properties -emit-llvm -g %s -o - | FileCheck %s
+__attribute((objc_root_class)) @interface NSObject {
+	id isa;
+}
++ (id)alloc;
+- (id)init;
+- (id)retain;
+ at end
+
+void NSLog(id, ...);
+
+ at protocol MyProtocol
+
+-(const char *)hello;
+
+ at end
+
+ at interface MyClass : NSObject {
+}
+
+ at property (nonatomic, assign) id <MyProtocol> bad_carrier;
+ at property (nonatomic, assign) id good_carrier;
+
+ at end
+
+ at implementation MyClass
+ at end
+
+int main()
+{
+    @autoreleasepool
+    {
+        MyClass *my_class = [MyClass alloc];
+        NSLog(@"%p\n", my_class.bad_carrier);
+        NSLog(@"%p\n", my_class.good_carrier);
+    }
+}
+// Verify that the debug type for both variables is 'id'.
+// CHECK: metadata !{i32 {{[0-9]+}}, metadata !{{[0-9]+}}, metadata !"bad_carrier", metadata !{{[0-9]+}}, i32 {{[0-9]+}}, metadata ![[IDTYPE:[0-9]+]], i32 0, i32 0} ; [ DW_TAG_arg_variable ] [bad_carrier] [line 21]
+// CHECK: metadata !{i32 {{[0-9]+}}, metadata !{{[0-9]+}}, metadata !"good_carrier", metadata !{{[0-9]+}}, i32 {{[0-9]+}}, metadata !{{.*}}[[IDTYPE]], i32 0, i32 0} ; [ DW_TAG_arg_variable ] [good_carrier] [line 22]
+// CHECK !{{.*}}[[IDTYPE]] = metadata !{i32 {{[0-9]+}}, null, metadata !"id", metadata !{{[0-9]+}}, i32 !{{[0-9]+}}, i64 0, i64 0, i64 0, i32 0, metadata !{{[0-9]+}}} ; [ DW_TAG_typedef ] [id]