r175613 - Implements breaking of string literals if they stick out.

Dmitri Gribenko gribozavr at gmail.com
Thu Feb 21 05:10:29 PST 2013


On Thu, Feb 21, 2013 at 11:15 AM, Manuel Klimek <klimek at google.com> wrote:
> On Wed, Feb 20, 2013 at 11:53 AM, Dmitri Gribenko <gribozavr at gmail.com>
> wrote:
>>
>> On Wed, Feb 20, 2013 at 12:15 PM, Manuel Klimek <klimek at google.com> wrote:
>> > +  EXPECT_EQ("f(\"some \"\n"
>> > +            "  \"text\",\n"
>> > +            "  other);",
>> > +            format("f(\"some text\", other);",
>> > getLLVMStyleWithColumns(10)));
>> > +}
>>
>> I think we could accidentally get a digraph or a trigraph after
>> merging string literals.
>
> I'm not sure what you're saying - we don't merge string literals - we just
> split them.

Oh, then it is the opposite -- we could split a trigraph.  But they
are rarely used, so we could probably ignore them (or not?)

Dmitri

-- 
main(i,j){for(i=2;;i++){for(j=2;j<i;j++){if(!(i%j)){j=0;break;}}if
(j){printf("%d\n",i);}}} /*Dmitri Gribenko <gribozavr at gmail.com>*/



More information about the cfe-commits mailing list