[PATCH] [clang] dont special case the ARMv7 FPU

Saleem Abdulrasool compnerd at compnerd.org
Tue Feb 19 13:50:22 PST 2013


Hi echristo, grosbach,

ARMv7 chipsets usually are paired with a NEON FPU.  However, this is not
required (e.g. tegra2).  Rather than always forcing NEON as the FPU for ARMv7
chips, honour the -mfpu flag, which already is being done.  If -mfpu is not
specified, then let the default FPU remain selected (VFP).

Signed-off-by: Saleem Abdulrasool <compnerd at compnerd.org>


http://llvm-reviews.chandlerc.com/D425

Files:
  lib/Driver/Tools.cpp

Index: lib/Driver/Tools.cpp
===================================================================
--- lib/Driver/Tools.cpp
+++ lib/Driver/Tools.cpp
@@ -5494,10 +5494,6 @@
     CmdArgs.push_back("-mppc64");
     CmdArgs.push_back("-many");
   } else if (getToolChain().getArch() == llvm::Triple::arm) {
-    StringRef MArch = getToolChain().getArchName();
-    if (MArch == "armv7" || MArch == "armv7a" || MArch == "armv7-a")
-      CmdArgs.push_back("-mfpu=neon");
-
     StringRef ARMFloatABI = getARMFloatABI(getToolChain().getDriver(), Args,
                                            getToolChain().getTriple());
     CmdArgs.push_back(Args.MakeArgString("-mfloat-abi=" + ARMFloatABI));
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D425.1.patch
Type: text/x-patch
Size: 690 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130219/27d59ebe/attachment.bin>


More information about the cfe-commits mailing list