r175483 - Fixing a typo where FixIts was accidentally self-assigning instead of assigning in the parameter Fixits. This fixes several failed assertions with MSVC debug builds.

[Aaron Ballman]

On Mon, Feb 18, 2013 at 10:56 PM, Chandler Carruth <chandlerc at google.com> wrote:
> On Mon, Feb 18, 2013 at 6:32 PM, Aaron Ballman <aaron at aaronballman.com>
> wrote:
>>
>> Author: aaronballman
>> Date: Mon Feb 18 20:32:05 2013
>> New Revision: 175483
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=175483&view=rev
>> Log:
>> Fixing a typo where FixIts was accidentally self-assigning instead of
>> assigning in the parameter Fixits. This fixes several failed assertions with
>> MSVC debug builds.
>
>
> Err, I think the fix should be to name the parameter FixIts. We often
> specifically alias the member in the constructor parameter name so that it's
> harder to typo.

That's fair, though it does tend to make things more confusing IMO
(now you're required to use this-> to differentiate between two
identically-named identifiers).

> Also, why is this using the assign member rather than using the 2-argument
> constructor in the init list?

It's been this way since 2011 -- I made as small of a change as
possible.  If you'd prefer though, I can move it to the initializer
list and rename the parameter.

~Aaron