[PATCH] Fix for Bug 7256 - clang++ should provide a fix-it hint for incorrect destructor declarations

Ismail Pazarbasi ismail.pazarbasi at gmail.com
Mon Feb 18 16:11:20 PST 2013


On Tue, Feb 19, 2013 at 12:43 AM, Dmitri Gribenko <gribozavr at gmail.com> wrote:
> On Tue, Feb 19, 2013 at 1:02 AM, Ismail Pazarbasi
> <ismail.pazarbasi at gmail.com> wrote:
> <0001-Fix-for-Bug-7256-clang-should-provide-a-fix-it-hint-.patch>
>
> +      if (const CXXRecordDecl* Class = dyn_cast_or_null<CXXRecordDecl>(Ctx))
>
> LLVM style is to put space before the star.
>
> Dmitri
>
> --
> main(i,j){for(i=2;;i++){for(j=2;j<i;j++){if(!(i%j)){j=0;break;}}if
> (j){printf("%d\n",i);}}} /*Dmitri Gribenko <gribozavr at gmail.com>*/

I have fixed the whitespace issue.

Could you please check whether the patch for the test is correct? I
have added a line of RUN command/instruction with
-fdiagnostics-parseable-fixits based on the one in test/FixIt/typo.c.
I hope I've got that right.

Thanks!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Fix-for-Bug-7256-clang-should-provide-a-fix-it-hint-.patch
Type: application/octet-stream
Size: 2184 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130219/593641b1/attachment.obj>


More information about the cfe-commits mailing list