[PATCH] Fix for Bug 7256 - clang++ should provide a fix-it hint for incorrect destructor declarations

David Blaikie dblaikie at gmail.com
Mon Feb 18 13:50:15 PST 2013


On Mon, Feb 18, 2013 at 1:40 PM, Ismail Pazarbasi <
ismail.pazarbasi at gmail.com> wrote:

> Hi,
>
> I have made this a while ago, but didn't have a chance to submit it.
>
> When an invalid destructor name is found within a class scope, a
> fix-it hint will be issued to correct the destructor name so that it
> matches the class name.


Looks pretty good. Rather than adding another test file - perhaps you could
just add this fixit case to the general test/FixIt/fixit.cpp or similarly
general test case (avoiding extra process invocations keeps the regression
test execution time down)

For future reference: providing a single patch that includes both
production changes & tests is fine/easy/good.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130218/17801fc9/attachment.html>


More information about the cfe-commits mailing list