PATCH: private ivars

jahanian fjahanian at apple.com
Fri Feb 15 16:16:48 PST 2013


Few comments all related to all_declared_ivar_begin only.

There is only one implementation per class. Please do not mention "all implementations" in code comment.
Do not change the indentations. It has added to the diff making it harder to review.
Make sure this patch does not add same ivar to the list more than once if it is called for
debug info. multiple times. Does you patch prevent that? (Note that we have ivars in primary class,
in multiple class extensions and one class implementation). No matter how this routine is called per
each top-level declaration, no duplicate ivar should be added to the list.

- Fariborz

On Feb 15, 2013, at 3:45 PM, Adrian Prantl <aprantl at apple.com> wrote:

> 
> On Feb 15, 2013, at 3:06 PM, jahanian <fjahanian at apple.com> wrote:
> 
>> ObjCInterfaceDecl::all_declared_ivar_begin has changed recently. You need to apply the patch against
>> current revision and make sure all clang tests pass after that.
> 
> Thanks for noticing, Fariborz! Here is a rebased patch that passes the regression suite.
> 
> Adrian
> 
> <private-ivars.patch>




More information about the cfe-commits mailing list