[PATCH] clang-c: Add clang_getTypeSpelling()

Dmitri Gribenko gribozavr at gmail.com
Thu Feb 14 13:18:30 PST 2013



================
Comment at: include/clang-c/Index.h:2698-2700
@@ -2697,1 +2697,5 @@
 /**
+ * \brief Retrieve the spelling of a given CXType.
+ * \returns the spelling of the type. This string must be freed
+ * via a call to \c clang_disposeString().
+ */
----------------
Dmitri Gribenko wrote:
> (1) No need to refer to clang_disposeString -- it should be called for all CXStrings.
> 
> (2) \returns part just duplicates the brief.  It would be better to expand the \brief to explain what 'spelling' is -- a string pretty-printed according to the language syntax.
Please also bump CINDEX_VERSION_MINOR.


http://llvm-reviews.chandlerc.com/D409



More information about the cfe-commits mailing list