[libcxx] r174721 - [tests] Increase a bunch of wait limits.

Daniel Dunbar daniel at zuster.org
Fri Feb 8 09:41:19 PST 2013


Author: ddunbar
Date: Fri Feb  8 11:41:19 2013
New Revision: 174721

URL: http://llvm.org/viewvc/llvm-project?rev=174721&view=rev
Log:
[tests] Increase a bunch of wait limits.

 - Basically I just ran the thread tests many many times on a busy machine and
   bumped the timeouts whenever I hit a test failure.

 - This is obviously subpar, but is the best I can do without the tests being
   rewritten to not depend on arbitrary timeouts.

Modified:
    libcxx/trunk/test/thread/thread.condition/thread.condition.condvarany/wait_until.pass.cpp
    libcxx/trunk/test/thread/thread.mutex/thread.lock/thread.lock.guard/adopt_lock.pass.cpp
    libcxx/trunk/test/thread/thread.mutex/thread.lock/thread.lock.guard/mutex.pass.cpp
    libcxx/trunk/test/thread/thread.mutex/thread.lock/thread.lock.unique/thread.lock.unique.cons/mutex.pass.cpp
    libcxx/trunk/test/thread/thread.mutex/thread.lock/thread.lock.unique/thread.lock.unique.cons/mutex_time_point.pass.cpp
    libcxx/trunk/test/thread/thread.mutex/thread.mutex.requirements/thread.mutex.requirements.mutex/thread.mutex.class/lock.pass.cpp
    libcxx/trunk/test/thread/thread.mutex/thread.mutex.requirements/thread.mutex.requirements.mutex/thread.mutex.class/try_lock.pass.cpp
    libcxx/trunk/test/thread/thread.mutex/thread.mutex.requirements/thread.mutex.requirements.mutex/thread.mutex.recursive/try_lock.pass.cpp
    libcxx/trunk/test/thread/thread.mutex/thread.mutex.requirements/thread.timedmutex.requirements/thread.timedmutex.class/try_lock.pass.cpp
    libcxx/trunk/test/thread/thread.mutex/thread.mutex.requirements/thread.timedmutex.requirements/thread.timedmutex.class/try_lock_for.pass.cpp
    libcxx/trunk/test/thread/thread.mutex/thread.mutex.requirements/thread.timedmutex.requirements/thread.timedmutex.recursive/try_lock.pass.cpp

Modified: libcxx/trunk/test/thread/thread.condition/thread.condition.condvarany/wait_until.pass.cpp
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/thread/thread.condition/thread.condition.condvarany/wait_until.pass.cpp?rev=174721&r1=174720&r2=174721&view=diff
==============================================================================
--- libcxx/trunk/test/thread/thread.condition/thread.condition.condvarany/wait_until.pass.cpp (original)
+++ libcxx/trunk/test/thread/thread.condition/thread.condition.condvarany/wait_until.pass.cpp Fri Feb  8 11:41:19 2013
@@ -68,7 +68,7 @@ void f()
     }
     else
     {
-        assert(t1 - t0 - Clock::duration(250) < Clock::duration(5));
+        assert(t1 - t0 - Clock::duration(250) < Clock::duration(50));
         assert(test2 == 0);
     }
     ++runs;

Modified: libcxx/trunk/test/thread/thread.mutex/thread.lock/thread.lock.guard/adopt_lock.pass.cpp
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/thread/thread.mutex/thread.lock/thread.lock.guard/adopt_lock.pass.cpp?rev=174721&r1=174720&r2=174721&view=diff
==============================================================================
--- libcxx/trunk/test/thread/thread.mutex/thread.lock/thread.lock.guard/adopt_lock.pass.cpp (original)
+++ libcxx/trunk/test/thread/thread.mutex/thread.lock/thread.lock.guard/adopt_lock.pass.cpp Fri Feb  8 11:41:19 2013
@@ -36,7 +36,7 @@ void f()
     t1 = Clock::now();
     }
     ns d = t1 - t0 - ms(250);
-    assert(d < ns(2500000));  // within 2.5ms
+    assert(d < ms(50));  // within 50ms
 }
 
 int main()

Modified: libcxx/trunk/test/thread/thread.mutex/thread.lock/thread.lock.guard/mutex.pass.cpp
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/thread/thread.mutex/thread.lock/thread.lock.guard/mutex.pass.cpp?rev=174721&r1=174720&r2=174721&view=diff
==============================================================================
--- libcxx/trunk/test/thread/thread.mutex/thread.lock/thread.lock.guard/mutex.pass.cpp (original)
+++ libcxx/trunk/test/thread/thread.mutex/thread.lock/thread.lock.guard/mutex.pass.cpp Fri Feb  8 11:41:19 2013
@@ -35,7 +35,7 @@ void f()
     t1 = Clock::now();
     }
     ns d = t1 - t0 - ms(250);
-    assert(d < ns(2500000));  // within 2.5ms
+    assert(d < ms(200));  // within 200ms
 }
 
 int main()

Modified: libcxx/trunk/test/thread/thread.mutex/thread.lock/thread.lock.unique/thread.lock.unique.cons/mutex.pass.cpp
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/thread/thread.mutex/thread.lock/thread.lock.unique/thread.lock.unique.cons/mutex.pass.cpp?rev=174721&r1=174720&r2=174721&view=diff
==============================================================================
--- libcxx/trunk/test/thread/thread.mutex/thread.lock/thread.lock.unique/thread.lock.unique.cons/mutex.pass.cpp (original)
+++ libcxx/trunk/test/thread/thread.mutex/thread.lock/thread.lock.unique/thread.lock.unique.cons/mutex.pass.cpp Fri Feb  8 11:41:19 2013
@@ -35,7 +35,7 @@ void f()
     t1 = Clock::now();
     }
     ns d = t1 - t0 - ms(250);
-    assert(d < ns(2500000));  // within 2.5ms
+    assert(d < ms(50));  // within 50ms
 }
 
 int main()

Modified: libcxx/trunk/test/thread/thread.mutex/thread.lock/thread.lock.unique/thread.lock.unique.cons/mutex_time_point.pass.cpp
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/thread/thread.mutex/thread.lock/thread.lock.unique/thread.lock.unique.cons/mutex_time_point.pass.cpp?rev=174721&r1=174720&r2=174721&view=diff
==============================================================================
--- libcxx/trunk/test/thread/thread.mutex/thread.lock/thread.lock.unique/thread.lock.unique.cons/mutex_time_point.pass.cpp (original)
+++ libcxx/trunk/test/thread/thread.mutex/thread.lock/thread.lock.unique/thread.lock.unique.cons/mutex_time_point.pass.cpp Fri Feb  8 11:41:19 2013
@@ -44,7 +44,7 @@ void f2()
     assert(lk.owns_lock() == false);
     time_point t1 = Clock::now();
     ns d = t1 - t0 - ms(250);
-    assert(d < ns(5000000));  // within 5ms
+    assert(d < ms(50));  // within 50ms
 }
 
 int main()

Modified: libcxx/trunk/test/thread/thread.mutex/thread.mutex.requirements/thread.mutex.requirements.mutex/thread.mutex.class/lock.pass.cpp
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/thread/thread.mutex/thread.mutex.requirements/thread.mutex.requirements.mutex/thread.mutex.class/lock.pass.cpp?rev=174721&r1=174720&r2=174721&view=diff
==============================================================================
--- libcxx/trunk/test/thread/thread.mutex/thread.mutex.requirements/thread.mutex.requirements.mutex/thread.mutex.class/lock.pass.cpp (original)
+++ libcxx/trunk/test/thread/thread.mutex/thread.mutex.requirements/thread.mutex.requirements.mutex/thread.mutex.class/lock.pass.cpp Fri Feb  8 11:41:19 2013
@@ -35,7 +35,7 @@ void f()
     time_point t1 = Clock::now();
     m.unlock();
     ns d = t1 - t0 - ms(250);
-    assert(d < ns(2500000));  // within 2.5ms
+    assert(d < ms(50));  // within 50ms
 }
 
 int main()

Modified: libcxx/trunk/test/thread/thread.mutex/thread.mutex.requirements/thread.mutex.requirements.mutex/thread.mutex.class/try_lock.pass.cpp
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/thread/thread.mutex/thread.mutex.requirements/thread.mutex.requirements.mutex/thread.mutex.class/try_lock.pass.cpp?rev=174721&r1=174720&r2=174721&view=diff
==============================================================================
--- libcxx/trunk/test/thread/thread.mutex/thread.mutex.requirements/thread.mutex.requirements.mutex/thread.mutex.class/try_lock.pass.cpp (original)
+++ libcxx/trunk/test/thread/thread.mutex/thread.mutex.requirements/thread.mutex.requirements.mutex/thread.mutex.class/try_lock.pass.cpp Fri Feb  8 11:41:19 2013
@@ -37,7 +37,7 @@ void f()
     time_point t1 = Clock::now();
     m.unlock();
     ns d = t1 - t0 - ms(250);
-    assert(d < ns(50000000));  // within 50ms
+    assert(d < ms(200));  // within 200ms
 }
 
 int main()

Modified: libcxx/trunk/test/thread/thread.mutex/thread.mutex.requirements/thread.mutex.requirements.mutex/thread.mutex.recursive/try_lock.pass.cpp
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/thread/thread.mutex/thread.mutex.requirements/thread.mutex.requirements.mutex/thread.mutex.recursive/try_lock.pass.cpp?rev=174721&r1=174720&r2=174721&view=diff
==============================================================================
--- libcxx/trunk/test/thread/thread.mutex/thread.mutex.requirements/thread.mutex.requirements.mutex/thread.mutex.recursive/try_lock.pass.cpp (original)
+++ libcxx/trunk/test/thread/thread.mutex/thread.mutex.requirements/thread.mutex.requirements.mutex/thread.mutex.recursive/try_lock.pass.cpp Fri Feb  8 11:41:19 2013
@@ -39,7 +39,7 @@ void f()
     m.unlock();
     m.unlock();
     ns d = t1 - t0 - ms(250);
-    assert(d < ns(50000000));  // within 50ms
+    assert(d < ms(200));  // within 200ms
 }
 
 int main()

Modified: libcxx/trunk/test/thread/thread.mutex/thread.mutex.requirements/thread.timedmutex.requirements/thread.timedmutex.class/try_lock.pass.cpp
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/thread/thread.mutex/thread.mutex.requirements/thread.timedmutex.requirements/thread.timedmutex.class/try_lock.pass.cpp?rev=174721&r1=174720&r2=174721&view=diff
==============================================================================
--- libcxx/trunk/test/thread/thread.mutex/thread.mutex.requirements/thread.timedmutex.requirements/thread.timedmutex.class/try_lock.pass.cpp (original)
+++ libcxx/trunk/test/thread/thread.mutex/thread.mutex.requirements/thread.timedmutex.requirements/thread.timedmutex.class/try_lock.pass.cpp Fri Feb  8 11:41:19 2013
@@ -37,7 +37,7 @@ void f()
     time_point t1 = Clock::now();
     m.unlock();
     ns d = t1 - t0 - ms(250);
-    assert(d < ns(50000000));  // within 50ms
+    assert(d < ms(200));  // within 200ms
 }
 
 int main()

Modified: libcxx/trunk/test/thread/thread.mutex/thread.mutex.requirements/thread.timedmutex.requirements/thread.timedmutex.class/try_lock_for.pass.cpp
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/thread/thread.mutex/thread.mutex.requirements/thread.timedmutex.requirements/thread.timedmutex.class/try_lock_for.pass.cpp?rev=174721&r1=174720&r2=174721&view=diff
==============================================================================
--- libcxx/trunk/test/thread/thread.mutex/thread.mutex.requirements/thread.timedmutex.requirements/thread.timedmutex.class/try_lock_for.pass.cpp (original)
+++ libcxx/trunk/test/thread/thread.mutex/thread.mutex.requirements/thread.timedmutex.requirements/thread.timedmutex.class/try_lock_for.pass.cpp Fri Feb  8 11:41:19 2013
@@ -34,7 +34,7 @@ void f1()
     time_point t1 = Clock::now();
     m.unlock();
     ns d = t1 - t0 - ms(250);
-    assert(d < ns(5000000));  // within 5ms
+    assert(d < ms(50));  // within 50ms
 }
 
 void f2()
@@ -43,7 +43,7 @@ void f2()
     assert(m.try_lock_for(ms(250)) == false);
     time_point t1 = Clock::now();
     ns d = t1 - t0 - ms(250);
-    assert(d < ns(5000000));  // within 5ms
+    assert(d < ms(50));  // within 50ms
 }
 
 int main()

Modified: libcxx/trunk/test/thread/thread.mutex/thread.mutex.requirements/thread.timedmutex.requirements/thread.timedmutex.recursive/try_lock.pass.cpp
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/thread/thread.mutex/thread.mutex.requirements/thread.timedmutex.requirements/thread.timedmutex.recursive/try_lock.pass.cpp?rev=174721&r1=174720&r2=174721&view=diff
==============================================================================
--- libcxx/trunk/test/thread/thread.mutex/thread.mutex.requirements/thread.timedmutex.requirements/thread.timedmutex.recursive/try_lock.pass.cpp (original)
+++ libcxx/trunk/test/thread/thread.mutex/thread.mutex.requirements/thread.timedmutex.requirements/thread.timedmutex.recursive/try_lock.pass.cpp Fri Feb  8 11:41:19 2013
@@ -39,7 +39,7 @@ void f()
     m.unlock();
     m.unlock();
     ns d = t1 - t0 - ms(250);
-    assert(d < ns(50000000));  // within 50ms
+    assert(d < ms(200));  // within 200ms
 }
 
 int main()





More information about the cfe-commits mailing list