[PATCH] Support for floating point vector logical operations

Joey Gouly joey.gouly at arm.com
Fri Feb 8 09:10:40 PST 2013

Hi all!

This patch adds support for floating point logical operations for OpenCL
1.2, and errors for OpenCL 1.1.

VisitUnaryLNot, VisitBinLAnd and VisitBinLOr were changed to support
floating point types.

In lib/Sema/SemaExpr.cpp, CheckVectorLogicalOperands, there was a line:
> if (vType.isNull() || vType->isFloatingType())
I don't think the isFloatingType() could ever be true, since the type from
CheckVectorOperands would always be a VectorType?
I removed this part, and did a build/test and nothing failed, so I think it
was dead code.

Any comments?

-------------- next part --------------
A non-text attachment was scrubbed...
Name: logical_ops.diff
Type: application/octet-stream
Size: 12304 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130208/d05dcf50/attachment.obj>

More information about the cfe-commits mailing list