[PATCH]Handle intel_ocl_bicc calling convention

Benyei, Guy guy.benyei at intel.com
Thu Feb 7 14:34:33 PST 2013

Thanks John. Here is the fixed patch.
Any other comments?


-----Original Message-----
From: John McCall [mailto:rjmccall at apple.com] 
Sent: Thursday, February 07, 2013 21:50
To: Benyei, Guy
Cc: cfe-commits at cs.uiuc.edu
Subject: Re: [PATCH]Handle intel_ocl_bicc calling convention

On Feb 6, 2013, at 6:05 AM, "Benyei, Guy" <guy.benyei at intel.com> wrote:
> Attached a patch, which changes the ABI for functions with intel_ocl_bicc for x86_64 non-windows targets.
> This patch is needed to support the Intel OpenCL builtin library.

-    unsigned neededInt, neededSSE;
-    it->info = classifyArgumentType(it->type, freeIntRegs, neededInt,
-                                    neededSSE);
+    if (FI.getCallingConvention() == llvm::CallingConv::Intel_OCL_BI)
+      it->info = classifyOCLBIType(it->type);
+    else {

Instead of reindenting the main loop body, please just do this at the top:

  if (FI.getCallingConvention() == llvm::CallingConv::Intel_OCL_BI) {
    it->info = classifyOCLBIType(it->type);


Intel Israel (74) Limited

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: inteloclbicc_ABI2.patch
Type: application/octet-stream
Size: 2099 bytes
Desc: inteloclbicc_ABI2.patch
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130207/5525f337/attachment.obj>

More information about the cfe-commits mailing list