r174621 - Only check for volatile memcpys in test.

Jordan Rose jordan_rose at apple.com
Thu Feb 7 09:18:19 PST 2013


Oops, my fault for reading commits in chronological order. Thanks, Tim!


On Feb 7, 2013, at 9:17 , Jordan Rose <jordan_rose at apple.com> wrote:

> Actually, while you're here it would be nice to change this to a FileCheck-based test...
> 
> 
> On Feb 7, 2013, at 7:11 , Tim Northover <Tim.Northover at arm.com> wrote:
> 
>> Author: tnorthover
>> Date: Thu Feb  7 09:11:48 2013
>> New Revision: 174621
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=174621&view=rev
>> Log:
>> Only check for volatile memcpys in test.
>> 
>> AArch64 handles aggFct's return struct slightly differently, leading
>> to an extra memcpy. This test is fortunately only concerned about
>> volatile copies, so we can modify the grep text to filter it.
>> 
>> Modified:
>>   cfe/trunk/test/CodeGen/volatile.c
>> 
>> Modified: cfe/trunk/test/CodeGen/volatile.c
>> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGen/volatile.c?rev=174621&r1=174620&r2=174621&view=diff
>> ==============================================================================
>> --- cfe/trunk/test/CodeGen/volatile.c (original)
>> +++ cfe/trunk/test/CodeGen/volatile.c Thu Feb  7 09:11:48 2013
>> @@ -1,6 +1,6 @@
>> // RUN: %clang_cc1 -emit-llvm < %s -o %t
>> // RUN: grep volatile %t | count 28
>> -// RUN: grep memcpy %t | count 7
>> +// RUN: grep "memcpy.*, i1 true" %t | count 6
>> 
>> // The number 28 comes from the current codegen for volatile loads;
>> // if this number changes, it's not necessarily something wrong, but
>> 
>> 
>> _______________________________________________
>> cfe-commits mailing list
>> cfe-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
> 




More information about the cfe-commits mailing list