[PATCH] Be yet more clever about -Wunused-value in macros

Richard Smith richard at metafoo.co.uk
Wed Feb 6 15:42:34 PST 2013

Comment at: lib/Sema/SemaStmt.cpp:169
@@ +168,3 @@
+  if (SourceMgr.isMacroBodyExpansion(ExprLoc) &&
+      !(isa<CallExpr>(E->IgnoreParens()) &&
+        E->getLocStart().isMacroID() &&
The ad-hoc nature of this check gives me pause. I'd be more comfortable saying that __attribute__((warn_unused_result)) always gives a warning, even in a macro body.


More information about the cfe-commits mailing list