[libcxx] r174539 - Give a lot more timing latitude to some of the timing tests. Busy buildbots are hitting the timing limits too often.

Howard Hinnant hhinnant at apple.com
Wed Feb 6 12:25:56 PST 2013


Author: hhinnant
Date: Wed Feb  6 14:25:56 2013
New Revision: 174539

URL: http://llvm.org/viewvc/llvm-project?rev=174539&view=rev
Log:
Give a lot more timing latitude to some of the timing tests. Busy buildbots are hitting the timing limits too often.

Modified:
    libcxx/trunk/test/thread/thread.condition/thread.condition.condvarany/wait_for_pred.pass.cpp
    libcxx/trunk/test/thread/thread.mutex/thread.lock/thread.lock.unique/thread.lock.unique.cons/mutex_duration.pass.cpp
    libcxx/trunk/test/thread/thread.mutex/thread.lock/thread.lock.unique/thread.lock.unique.locking/lock.pass.cpp
    libcxx/trunk/test/thread/thread.mutex/thread.mutex.requirements/thread.timedmutex.requirements/thread.timedmutex.class/try_lock_until.pass.cpp
    libcxx/trunk/test/thread/thread.mutex/thread.mutex.requirements/thread.timedmutex.requirements/thread.timedmutex.recursive/try_lock_until.pass.cpp

Modified: libcxx/trunk/test/thread/thread.condition/thread.condition.condvarany/wait_for_pred.pass.cpp
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/thread/thread.condition/thread.condition.condvarany/wait_for_pred.pass.cpp?rev=174539&r1=174538&r2=174539&view=diff
==============================================================================
--- libcxx/trunk/test/thread/thread.condition/thread.condition.condvarany/wait_for_pred.pass.cpp (original)
+++ libcxx/trunk/test/thread/thread.condition/thread.condition.condvarany/wait_for_pred.pass.cpp Wed Feb  6 14:25:56 2013
@@ -61,7 +61,7 @@ void f()
     }
     else
     {
-        assert(t1 - t0 - milliseconds(250) < milliseconds(5));
+        assert(t1 - t0 - milliseconds(250) < milliseconds(50));
         assert(test2 == 0);
     }
     ++runs;

Modified: libcxx/trunk/test/thread/thread.mutex/thread.lock/thread.lock.unique/thread.lock.unique.cons/mutex_duration.pass.cpp
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/thread/thread.mutex/thread.lock/thread.lock.unique/thread.lock.unique.cons/mutex_duration.pass.cpp?rev=174539&r1=174538&r2=174539&view=diff
==============================================================================
--- libcxx/trunk/test/thread/thread.mutex/thread.lock/thread.lock.unique/thread.lock.unique.cons/mutex_duration.pass.cpp (original)
+++ libcxx/trunk/test/thread/thread.mutex/thread.lock/thread.lock.unique/thread.lock.unique.cons/mutex_duration.pass.cpp Wed Feb  6 14:25:56 2013
@@ -34,7 +34,7 @@ void f1()
     assert(lk.owns_lock() == true);
     time_point t1 = Clock::now();
     ns d = t1 - t0 - ms(250);
-    assert(d < ns(5000000));  // within 5ms
+    assert(d < ms(50));  // within 50ms
 }
 
 void f2()
@@ -44,7 +44,7 @@ void f2()
     assert(lk.owns_lock() == false);
     time_point t1 = Clock::now();
     ns d = t1 - t0 - ms(250);
-    assert(d < ns(5000000));  // within 5ms
+    assert(d < ms(50));  // within 50ms
 }
 
 int main()

Modified: libcxx/trunk/test/thread/thread.mutex/thread.lock/thread.lock.unique/thread.lock.unique.locking/lock.pass.cpp
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/thread/thread.mutex/thread.lock/thread.lock.unique/thread.lock.unique.locking/lock.pass.cpp?rev=174539&r1=174538&r2=174539&view=diff
==============================================================================
--- libcxx/trunk/test/thread/thread.mutex/thread.lock/thread.lock.unique/thread.lock.unique.locking/lock.pass.cpp (original)
+++ libcxx/trunk/test/thread/thread.mutex/thread.lock/thread.lock.unique/thread.lock.unique.locking/lock.pass.cpp Wed Feb  6 14:25:56 2013
@@ -34,7 +34,7 @@ void f()
     time_point t1 = Clock::now();
     assert(lk.owns_lock() == true);
     ns d = t1 - t0 - ms(250);
-    assert(d < ns(2500000));  // within 2.5ms
+    assert(d < ms(25));  // within 25ms
     try
     {
         lk.lock();

Modified: libcxx/trunk/test/thread/thread.mutex/thread.mutex.requirements/thread.timedmutex.requirements/thread.timedmutex.class/try_lock_until.pass.cpp
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/thread/thread.mutex/thread.mutex.requirements/thread.timedmutex.requirements/thread.timedmutex.class/try_lock_until.pass.cpp?rev=174539&r1=174538&r2=174539&view=diff
==============================================================================
--- libcxx/trunk/test/thread/thread.mutex/thread.mutex.requirements/thread.timedmutex.requirements/thread.timedmutex.class/try_lock_until.pass.cpp (original)
+++ libcxx/trunk/test/thread/thread.mutex/thread.mutex.requirements/thread.timedmutex.requirements/thread.timedmutex.class/try_lock_until.pass.cpp Wed Feb  6 14:25:56 2013
@@ -34,7 +34,7 @@ void f1()
     time_point t1 = Clock::now();
     m.unlock();
     ns d = t1 - t0 - ms(250);
-    assert(d < ns(5000000));  // within 5ms
+    assert(d < ms(50));  // within 50ms
 }
 
 void f2()
@@ -43,7 +43,7 @@ void f2()
     assert(m.try_lock_until(Clock::now() + ms(250)) == false);
     time_point t1 = Clock::now();
     ns d = t1 - t0 - ms(250);
-    assert(d < ns(5000000));  // within 5ms
+    assert(d < ms(50));  // within 50ms
 }
 
 int main()

Modified: libcxx/trunk/test/thread/thread.mutex/thread.mutex.requirements/thread.timedmutex.requirements/thread.timedmutex.recursive/try_lock_until.pass.cpp
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/thread/thread.mutex/thread.mutex.requirements/thread.timedmutex.requirements/thread.timedmutex.recursive/try_lock_until.pass.cpp?rev=174539&r1=174538&r2=174539&view=diff
==============================================================================
--- libcxx/trunk/test/thread/thread.mutex/thread.mutex.requirements/thread.timedmutex.requirements/thread.timedmutex.recursive/try_lock_until.pass.cpp (original)
+++ libcxx/trunk/test/thread/thread.mutex/thread.mutex.requirements/thread.timedmutex.requirements/thread.timedmutex.recursive/try_lock_until.pass.cpp Wed Feb  6 14:25:56 2013
@@ -36,7 +36,7 @@ void f1()
     m.unlock();
     m.unlock();
     ns d = t1 - t0 - ms(250);
-    assert(d < ns(5000000));  // within 5ms
+    assert(d < ms(50));  // within 50ms
 }
 
 void f2()
@@ -45,7 +45,7 @@ void f2()
     assert(m.try_lock_until(Clock::now() + ms(250)) == false);
     time_point t1 = Clock::now();
     ns d = t1 - t0 - ms(250);
-    assert(d < ns(5000000));  // within 5ms
+    assert(d < ms(50));  // within 50ms
 }
 
 int main()





More information about the cfe-commits mailing list