[PATCH] [cfe-commits] r173697 - FileCheck'ize and merge tests

[Jordan Rose]

On Feb 6, 2013, at 5:44 , Dmitri Gribenko <gribozavr at gmail.com> wrote:

> On Wed, Feb 6, 2013 at 3:00 PM, Benyei, Guy <guy.benyei at intel.com> wrote:
>> Hi all,
>> --strict-whitespace also kills the dos to unix end of line canonicalization. This made 3 Clang LIT test fail on my Windows machine.
>> Attached a patch that makes this flag affect the horizontal whitespaces only, as it's stated in the flag's description.
> 
> This totally makes sense to me.  Nits:
> 
> 1. Please add to the flag description in docs/CommandGuide/FileCheck.rst
> "End-of-line sequences are canonicalized to UNIX-style '\r' in all modes."

UNIX-style '\n'. '\r' is Mac OS Classic style!


> 2. Please remove trailing whitespace from comments in your patch.
> 
> 3.
> 
> +/// CanonicalizeInputFile - Remove duplicate horizontal space and dos style
> +/// '\r' at end of linefrom the specified memory buffer, free it, and return
> +/// a new one.
> 
> Please remove function name from the comment.  It would also help to
> rephrase it like:
> 
> "Canonicalize whitespace in the input file.  Line endings are replaced
> with UNIX-style '\r'.
> 
> \param PreserveHorizontal Don't squash consecutive horizontal
> whitespace characters into a single space."
> 
> 4. Please add a test to test/FileCheck/
> 
> Dmitri
> 
> -- 
> main(i,j){for(i=2;;i++){for(j=2;j<i;j++){if(!(i%j)){j=0;break;}}if
> (j){printf("%d\n",i);}}} /*Dmitri Gribenko <gribozavr at gmail.com>*/
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits