[PATCH] RE: [cfe-commits] r173697 - FileCheck'ize and merge tests

Benyei, Guy guy.benyei at intel.com
Wed Feb 6 05:00:01 PST 2013


Hi all,
--strict-whitespace also kills the dos to unix end of line canonicalization. This made 3 Clang LIT test fail on my Windows machine.
Attached a patch that makes this flag affect the horizontal whitespaces only, as it's stated in the flag's description.

Please review.

Thanks
    Guy Benyei


-----Original Message-----
From: cfe-commits-bounces at cs.uiuc.edu [mailto:cfe-commits-bounces at cs.uiuc.edu] On Behalf Of Dmitri Gribenko
Sent: Monday, January 28, 2013 19:32
To: cfe-commits at cs.uiuc.edu
Subject: [cfe-commits] r173697 - FileCheck'ize and merge tests

Author: gribozavr
Date: Mon Jan 28 11:31:40 2013
New Revision: 173697

URL: http://llvm.org/viewvc/llvm-project?rev=173697&view=rev
Log:
FileCheck'ize and merge tests

Removed:
    cfe/trunk/test/Preprocessor/stringize_space2.c
Modified:
    cfe/trunk/test/Preprocessor/stringize_space.c

Modified: cfe/trunk/test/Preprocessor/stringize_space.c
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Preprocessor/stringize_space.c?rev=173697&r1=173696&r2=173697&view=diff
==============================================================================
--- cfe/trunk/test/Preprocessor/stringize_space.c (original)
+++ cfe/trunk/test/Preprocessor/stringize_space.c Mon Jan 28 11:31:40 2013
@@ -1,4 +1,14 @@
-// RUN: %clang_cc1 -E %s | grep -- '-"" , - "" , -"" , - ""'
+// RUN: %clang_cc1 -E %s | FileCheck --strict-whitespace %s
 
 #define A(b) -#b  ,  - #b  ,  -# b  ,  - # b
 A()
+
+// CHECK: {{^}}-"" , - "" , -"" , - ""{{$}}
+
+
+#define t(x) #x
+t(a
+c)
+
+// CHECK: {{^}}"a c"{{$}}
+

Removed: cfe/trunk/test/Preprocessor/stringize_space2.c
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Preprocessor/stringize_space2.c?rev=173696&view=auto
==============================================================================
--- cfe/trunk/test/Preprocessor/stringize_space2.c (original)
+++ cfe/trunk/test/Preprocessor/stringize_space2.c (removed)
@@ -1,6 +0,0 @@
-/* RUN: %clang_cc1 -E %s | grep 'a c'
- */
-#define t(x) #x
-t(a
-c)
-


_______________________________________________
cfe-commits mailing list
cfe-commits at cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
---------------------------------------------------------------------
Intel Israel (74) Limited

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: dos_eol_removal.patch
Type: application/octet-stream
Size: 2019 bytes
Desc: dos_eol_removal.patch
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130206/b3386b1d/attachment.obj>


More information about the cfe-commits mailing list