r174349 - Driver and option support for -gsplit-dwarf. This is a part of

[Eric Christopher]

On Tue, Feb 5, 2013 at 10:22 AM, Chandler Carruth <chandlerc at google.com>wrote:

> On Tue, Feb 5, 2013 at 10:12 AM, Eric Christopher <echristo at gmail.com>wrote:
>
>>
>>
>>
>> On Mon, Feb 4, 2013 at 11:47 PM, Chandler Carruth <chandlerc at google.com>wrote:
>>
>>>
>>> On Mon, Feb 4, 2013 at 11:29 PM, Eric Christopher <echristo at gmail.com>wrote:
>>>
>>>> +  // -gsplit-dwarf should turn on -g and enable the backend dwarf
>>>> +  // splitting and extraction.
>>>> +  if (Args.hasArg(options::OPT_gsplit_dwarf)) {
>>>> +    CmdArgs.push_back("-g");
>>>> +    CmdArgs.push_back("-backend-option");
>>>> +    CmdArgs.push_back("-split-dwarf=Enable");
>>>>
>>>
>>> This seems a strange flag spelling... Are there values other than
>>> "Enable"? I half expected just the standard binary '-split-debug' or
>>> nothing of CC1 options...
>>>
>>
>> Yeah, I put it as a tri-state Enable, Disable and Default so that we
>> could enable it easier by default for certain targets.
>>
>
> That kind of defaulting logic seems better to have in the driver than in
> CC1 to me.
>

It's actually in the backend and not cc1. The usage of the -gsplit-dwarf
means to enable it whether or not the backend would default to it or not.
The =Disable is just a way of turning it on/off via the backend.

-eric
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130205/836be563/attachment.html>