[PATCH] CodeGen: Implement the hint value for dyn_cast as described in the Itanium C++ ABI.

Chandler Carruth chandlerc at gmail.com
Sat Feb 2 14:42:59 PST 2013


  Looks good if andersca or someone familiar w/ this bit of codegen agrees...


================
Comment at: lib/CodeGen/CGExprCXX.cpp:1739-1740
@@ +1738,4 @@
+
+      // Accumulate the base class offsets.
+      if (NumPublicPaths == 0) {
+        const ASTRecordLayout &Layout = Context.getASTRecordLayout(J->Class);
----------------
continue instead?

I'm almost tempted to suggest unswitching this, and having two for loops...


http://llvm-reviews.chandlerc.com/D364



More information about the cfe-commits mailing list