[PATCH] Turn off missing field initializer warnings for gcc

[Edwin Vane]

Hi gribozavr, dblaikie,

gcc produces false positives for empty braces so turning the warning
off. Instead, turning the warning on for clang so proper warnings aren't
missed.

http://llvm-reviews.chandlerc.com/D358

Files:
  cmake/modules/HandleLLVMOptions.cmake

Index: cmake/modules/HandleLLVMOptions.cmake
===================================================================
--- cmake/modules/HandleLLVMOptions.cmake
+++ cmake/modules/HandleLLVMOptions.cmake
@@ -178,6 +178,14 @@
 elseif( LLVM_COMPILER_IS_GCC_COMPATIBLE )
   if (LLVM_ENABLE_WARNINGS)
     add_llvm_definitions( -Wall -W -Wno-unused-parameter -Wwrite-strings )
+    # Turn off missing field initializer warnings for gcc to avoid noise from
+    # false positives with empty {}. Turn them on otherwise (they're off by
+    # default for clang).
+    if (CMAKE_COMPILER_IS_GNUCXX)
+      add_llvm_definitions( -Wno-missing-field-initializers )
+    else()
+      add_llvm_definitions( -Wmissing-field-initializers )
+    endif()
     if (LLVM_ENABLE_PEDANTIC)
       add_llvm_definitions( -pedantic -Wno-long-long )
     endif (LLVM_ENABLE_PEDANTIC)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D358.1.patch
Type: text/x-patch
Size: 853 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130131/50c01d27/attachment.bin>