[PATCH] Move commonly useful code for AST testing into MatchVerfier.h.

Manuel Klimek klimek at google.com
Thu Jan 31 04:47:08 PST 2013


  I'm currently working on tests for the parent map patch I have open (adding getParents to the ASTContext), and needed pretty much exactly the same setup.

  I think your idea is right, but I'd want to wait for the next use case, and refactor afterwards, so we can make sure the design applies more broadly...


================
Comment at: unittests/AST/SourceLocationTest.cpp:57
@@ -221,3 +56,3 @@
   EXPECT_FALSE(Verifier.match("int i;", varDecl()));
 }
 
----------------
Philip Craig wrote:
> These tests belong to the MatchVerifier module. Might be worth putting in a FIXME to move them when we have a better spot to put them.
Done.


http://llvm-reviews.chandlerc.com/D352

BRANCH
  clang-ast-test

ARCANIST PROJECT
  clang



More information about the cfe-commits mailing list