[PATCH] Use const visitors in ASTDumper

Philip Craig philipjcraig at gmail.com
Thu Jan 31 04:04:35 PST 2013


This is a followup to an earlier review comment.

The new ConstDeclVisitor is modeled after ConstStmtVisitor. I had to put the DeclVisitor.h version of make_ptr/make_const_ptr in a namespace to avoid a conflict with StmtVisitor.h. Is there a common header that it would make sense to move these to?

There are still some const_cast for template specialization iterators. Removing those will take a bit more effort; let me know if you think it is worth doing.

http://llvm-reviews.chandlerc.com/D355

Files:
  include/clang/AST/DeclVisitor.h
  include/clang/AST/Expr.h
  lib/AST/ASTDumper.cpp
  lib/AST/Expr.cpp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D355.1.patch
Type: text/x-patch
Size: 41224 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130131/545e0f76/attachment.bin>


More information about the cfe-commits mailing list