[cfe-commits] [PATCH, RFC] Fix PR14881 (complex integer promotion rules)

[Bill Schmidt]

>Something along these lines, but I'd really prefer if you could somehow
>re-use the logic from handleIntegerConversion.  I think you could if you
>just made that function take function pointers to do the casts on the left
>and right parameters:
>
>  typedef ExprResult PerformCastFn(Sema &S, Expr *operand, QualType toType);
>  static QualType handleIntegerConversion(Sema &S, ExprResult &LHS,
>                                        ExprResult &RHS, QualType LHSType,
>                                        QualType RHSType, bool IsCompAssign,
>                                        PerformCastFn *doLHSCast, PerformCastFn *doRHSCast)
>
>The current use would just use a function like this:
>  ExprResult doIntegralCast(Sema &S, Expr *op, QualType toType) {
>    return S.ImpCastExprToType(op, toType, CK_IntegralCast);
>  }
>
>But whenever an operand is complex, you'd instead use:
>  ExprResult doComplexIntegralCast(Sema &S, Expr *op, QualType toType) {
>    return S.ImpCastExprToType(op, S.Context.getComplexType(toType), CK_ComplexIntegralCast);
>  }
>
>John.

Hm, ok, if you prefer.  My intent was to avoid any slowdown to the
common case of scalar integer conversion.  Complex integer is a GNU
extension used by -- well, practically nobody.  We need to support it
for completeness, but its use will be rare.  Using indirect calls incurs
some performance penalty, so I chose to leave the existing code alone.
But if you like, I'll cobble this up and see what it looks like.

(Sorry for losing the conversation threadedness; my mail server was down
over the weekend and I lost some messages, yours included...)

Bill