[cfe-commits] [Review, -cxx-abi microsoft] Implement proper handling of virtual destructors (single-inheritance case)

Timur Iskhodzhanov timurrrr at google.com
Fri Jan 25 09:34:13 PST 2013


Hi John,

Attached is a patch that allows me to pass all the single-inheritance
vdtor tests I've extracted while building and running Chromium.

It includes changing the deleting destructor to take an implicit bool
parameter when compiling in the Microsoft ABI.
Can you please take a look?
See also http://llvm.org/bugs/show_bug.cgi?id=15058 for the details.

The patch contains a couple of FIXMEs, I'd like to defer them for
later analysis if possible.

Note that I had to adjust the EmitCXXMemberCall interface slightly; I
think generalizing "VTT" to "implicit parameter in general" should be
OK.

Please tell me if I need to change anything.

--
Timur Iskhodzhanov,
Google Russia
-------------- next part --------------
A non-text attachment was scrubbed...
Name: bug_15058.patch
Type: application/octet-stream
Size: 25581 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130125/d6264c05/attachment.obj>


More information about the cfe-commits mailing list