[cfe-commits] r173377 - in /cfe/trunk: include/clang/AST/Expr.h include/clang/Basic/DiagnosticASTKinds.td include/clang/Basic/DiagnosticSemaKinds.td include/clang/Sema/Sema.h lib/AST/ExprConstant.cpp lib/Sema/SemaChecking.cpp lib/Sema/SemaDecl.cpp lib/Sema/SemaExprCXX.cpp lib/Sema/SemaStmt.cpp test/Sema/switch-1.c

jahanian fjahanian at apple.com
Thu Jan 24 14:27:50 PST 2013


On Jan 24, 2013, at 2:25 PM, Dmitri Gribenko <gribozavr at gmail.com> wrote:

>> ed?
>>     bool keepEvaluatingAfterFailure() {
>> -      return CheckingPotentialConstantExpression &&
>> -             EvalStatus.Diag && EvalStatus.Diag->empty();
>> +      // Should return true in IntOverflowCheckMode, so that we check for
>> +      // overflow even if some subexpressions can't be evaluated as constants.
>> +      // subexpressions can't be evaluated as constants.
> 
> Hi Fariborz,
> 
> Duplicate phrase here: "subexpressions can't be evaluated as constants."

Thanks. fixed in r173378.
- Fariborz

> 
> Dmitri
> 
> -- 
> main(i,j){for(i=2;;i++){for(j=2;j<i;j++){if(!(i%j)){j=0;break;}}if
> (j){printf("%d\n",i);}}} /*Dmitri Gribenko <gribozavr at gmail.com>*/




More information about the cfe-commits mailing list