[cfe-commits] [Patch] PR14922 - Improve Attr::printPretty

[Michael Han]

On Wed, Jan 23, 2013 at 9:10 PM, Richard Smith <richard at metafoo.co.uk>wrote:

> On Mon, Jan 21, 2013 at 8:12 PM, Michael Han <fragmentshaders at gmail.com>
> wrote:
> > Attach updated patch with more tests added; also updated all attributes
> to
> > include spelling index when their ast nodes are constructed.
> > OK to commit?
>
> +    OS <<
> +      "  case(" << I << ") : {\n"
>
> Remove the parens here.
>
> +  // end of the switch statement.
> +  OS << "}\n";
> +  // end of the print function.
>
> Please start these comments with a capital letter.
>
> Other than those tiny things, the patch looks good, but the test
> changes seem to be missing from the diff?
>

Yes the tests were missing from the diff, sorry about that. Attach the test
patch.

Michael
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130123/146734bf/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: attr-print-test.patch
Type: application/octet-stream
Size: 2973 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130123/146734bf/attachment.obj>