[cfe-commits] [PATCH] Addition of color to -ast-dump

[Philip Craig]

================
Comment at: include/clang/AST/DeclBase.h:853
@@ -852,2 +852,3 @@
   // Debuggers don't usually respect default arguments.
   LLVM_ATTRIBUTE_USED void dump() const;
+  // Same as dump(), but forces color printing.
----------------
Saleem Abdulrasool wrote:
> Philip Craig wrote:
> > Saleem Abdulrasool wrote:
> > > Why not make colour a default valued parameter for dump?  This would avoid duplication of the method as well as reduce the interface.
> > As the comment states, debuggers don't handle default arguments.
> Hmm, I wonder if there are many callers of this ... if not, it could be made a non-optional parameter.  I can understand not wanting to break the muscle memory of developers as a reason to not do so though.
The main argument would be for consistency with all the other dump() methods (there's more than just the ones in ASTDumper).


http://llvm-reviews.chandlerc.com/D291