[cfe-commits] [PATCH] Implement -Wvla correctly

[Chandler Carruth]

On Wed, Jan 23, 2013 at 11:53 AM, Dmitri Gribenko <gribozavr at gmail.com>wrote:

> On Tue, Jan 15, 2013 at 7:31 PM, Dmitri Gribenko <gribozavr at gmail.com>
> wrote:
> > On Tue, Jan 8, 2013 at 8:38 PM, Rafael Espíndola
> > <rafael.espindola at gmail.com> wrote:
> >> On 8 January 2013 11:31, Dmitri Gribenko <gribozavr at gmail.com> wrote:
> >>> Hello Rafael,
> >>>
> >>> I have added the requested tests.
> >>
> >> Cool. The patch look good to me. Just give chandler a day or so to
> >> comment on it. The google style bans VLAs, so he might have an opinion
> >> on the patch.
> >
> > Ping.
>
> Ping^2.
>
> Chandler: do you have concerns about this?


Sorry, I missed Rafael's comment. Google's style should have no bearing on
a warning. That doesn't make any sense.

This patch makes a lot of sense. I don't know what could be bad about it.

I assume the idea of warning about vla in general is for GCC compatibility
or security concerns? Seems reasonabl eto keep that functionality.

Anyways, don't wait for me, commit!
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130123/356e653d/attachment.html>