[cfe-commits] [llvm-commits] [patch] fp128 sint_to_fp folding fix

[Tim Northover]

Hi Richard,

> The AST dumper is a bit of a special case. It's intended to be usable
> by running Expr->dump() from a debugger, and consequently it does not
> have access to the ASTContext.

I thought it might be, which is why I stopped there.

> If this isn't working out well, how about replacing the IsIEEE flag in
> FloatingLiteralBitfields with a float kind enumeration?

Now that seems to have worked better; thanks for the suggestion. I've
attached the updated Clang patch, together with its LLVM counterpart
for reference.

Does it look reasonable to you?

Tim.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: apfloat-constructor-clang.diff
Type: application/octet-stream
Size: 9634 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130121/f6158b60/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: apfloat-constructor-llvm.diff
Type: application/octet-stream
Size: 31960 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130121/f6158b60/attachment-0001.obj>