[cfe-commits] [PATCH] AstUnit::LoadFromCompilerInvocation

[Dmitri Gribenko]

Hello Hurcan,

On Sat, Jan 19, 2013 at 4:44 AM, Hurcan Solter <hsolter at gmail.com> wrote:
> Unlike LoadFromCommandLine, LoadFromCompilerInvocation(the one with many
> arguments) causes a crash if Precompilepreamble is set to true because there
> is no FileManager at that point. Two methods are not in sync despite being
> very similar..

While this patch LGTM, I think that this function is dead code -- it
is not used by anything in clang.

Maybe it is better to remove this buggy function that nobody uses?  Argyrios?

Dmitri

-- 
main(i,j){for(i=2;;i++){for(j=2;j<i;j++){if(!(i%j)){j=0;break;}}if
(j){printf("%d\n",i);}}} /*Dmitri Gribenko <gribozavr at gmail.com>*/