[cfe-commits] [PATCH] Write transform results to disk only once

[Edwin Vane]

================
Comment at: cpp11-migrate/LoopConvert/LoopConvert.cpp:72
@@ -60,1 +71,3 @@
 
+  OwningPtr<RewriterContainer>
+    Rewrite(new RewriterContainer(LoopTool.getFiles()));
----------------
Manuel Klimek wrote:
> Any reason to not just do:
> RewriterContainer Rewrite(LoopTool.getFiles());
> ?
Not sure what I was thinking here. Using stack instead.

================
Comment at: cpp11-migrate/Transform.h:51
@@ -40,1 +50,3 @@
 
+typedef std::vector<std::pair<std::string, std::string> > RefactoringResults;
+
----------------
Manuel Klimek wrote:
> A comment what the pairs mean would be really helpful :)
> 
> We could also call this FileContentsByPath or something, which would help me greatly to understand the meaning from the name.
Comments added here and in some other places I noticed they were missing.

================
Comment at: cpp11-migrate/Transform.cpp:10
@@ +9,3 @@
+void collectResults(RefactoringResults &Results,
+                    clang::Rewriter &Rewrite) {
+  for (Rewriter::buffer_iterator I = Rewrite.buffer_begin(),
----------------
Manuel Klimek wrote:
> Personally, I'd put the output parameter last...
Done


http://llvm-reviews.chandlerc.com/D288