[cfe-commits] [patch][pr14766] Reject invalid redeclarations of extern C functions and variables

Rafael EspĂ­ndola rafael.espindola at gmail.com
Fri Jan 11 10:51:16 PST 2013


On 10 January 2013 21:51, Richard Smith <richard at metafoo.co.uk> wrote:
> +template<typename T>
> +static bool mayConflictWithNonVisibleExternC(const T *ND) {
> +  if (ND->hasCLanguageLinkage() && ND->getStorageClass() == SC_Extern)
> +    return true;
>
> Hmm, is this check equivalent to ND->isExternC() ?

No. To be honests I don't really understand what isExternC actually
is. It checks the linkage for example, which is problematic for code
that can run in places where we might not know it yet.

Cheers,
Rafael



More information about the cfe-commits mailing list