[cfe-commits] [PATCH 07/15] Fix Cast

[dag at cray.com]

Jordan Rose <jordan_rose at apple.com> writes:

> I agree with everyone else that even one patch per file is a bit
> unwieldy to review. Sean suggested putting everything in a single
> patch, since it's all the same issue, and for something like this that
> might not be so bad. If you're looking for a little more precision,
> one patch per library group (libclang, StaticAnalyzer, Sema, etc)
> might not be a bad idea because it's likely one person is qualified to
> review the entirety of each patch. (Which is why I'm not confirming
> the rest of these, even though they're probably correct.)

Ok, patch per library makes sense and in the future I'll group
patches for the same kind of warning/error.

> The splitting up of patches into separate e-mails from your
> introduction is also something not usually done on this list. 

Yes, I disabled this feature.  Stuff I send in the future will not
do that.

> I get that sometimes it's better to have separate threads for separate
> patches, but I don't think it would have hurt in this case to have
> everything coalesced.

Noted.  It's a judgement call and it's good to have a little more
guidance.  Thanks!

> Thanks for fixing all of these!

You bet!

                                -David