[cfe-commits] r172163 - /cfe/trunk/test/TableGen/tg-fixits.td

Jordan Rose jordan_rose at apple.com
Thu Jan 10 18:37:47 PST 2013


Author: jrose
Date: Thu Jan 10 20:37:47 2013
New Revision: 172163

URL: http://llvm.org/viewvc/llvm-project?rev=172163&view=rev
Log:
Revert "tg-fixits.td: fixup for Linux"

It's better to show no caret/ranges/fixits than to show them misaligned.
(It scares me a bit that Clang is going to show them misaligned on
systems without a proper llvm::sys::locale::columnWidth.) See PR14910.

This reverts commit a03cc72bedd015b7eb76e9ac650992f58a48549d.

Modified:
    cfe/trunk/test/TableGen/tg-fixits.td

Modified: cfe/trunk/test/TableGen/tg-fixits.td
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/TableGen/tg-fixits.td?rev=172163&r1=172162&r2=172163&view=diff
==============================================================================
--- cfe/trunk/test/TableGen/tg-fixits.td (original)
+++ cfe/trunk/test/TableGen/tg-fixits.td Thu Jan 10 20:37:47 2013
@@ -38,9 +38,4 @@
 def Unicode : Warning<"ユニコード">, InGroup<DiagGroup<"name">>;
 //      CHECK: tg-fixits.td:[[@LINE-1]]:51: error: group 'name' is referred to anonymously
 // CHECK-NEXT: def Unicode : Warning<"{{[^"]+}}">, InGroup<DiagGroup<"name">>;
-// Next two lines should not be printed, we get the underline wrong.  Our
-// implementation of diagnostic printing can skip printing these lines on some
-// OSes, but not on all.  See PR14910.
-// CHECK: {{(^                                          ~~~~~~~~\^~~~~~~~~~~~~~~~~~$)?}}
-// CHECK: {{(^                                          InGroup<NamedGroup>$)?}}
-// CHECK: note:
+// CHECK-NEXT: note:





More information about the cfe-commits mailing list