[cfe-commits] r171801 - in /cfe/trunk: lib/CodeGen/CGExprScalar.cpp test/CodeGen/compound-assign-overflow.c

[Will Dietz]

Poor internet here, my apologies for skipping a message in the thread.

Can you check if this still fails on trunk as Dmitri suggested?

Thanks!

~Will

On Wed, Jan 9, 2013 at 1:48 PM, Will Dietz <wdietz2 at illinois.edu> wrote:
> Sorry about that!
>
> Can you apply the attached patch (patch -p1 < patchfile) and confirm
> this fixes the issue for you?
>
> Thanks!
>
> ~Will
>
> On Wed, Jan 9, 2013 at 8:08 AM, İsmail Dönmez <ismail at donmez.ws> wrote:
>> Hi;
>>
>>
>> On Mon, Jan 7, 2013 at 11:25 PM, Will Dietz <wdietz2 at illinois.edu> wrote:
>>>
>>> Author: wdietz2
>>> Date: Mon Jan  7 16:25:52 2013
>>> New Revision: 171801
>>>
>>> URL: http://llvm.org/viewvc/llvm-project?rev=171801&view=rev
>>> Log:
>>> [ubsan] Use correct type for compound assignment ops.
>>>
>>> Added:
>>>     cfe/trunk/test/CodeGen/compound-assign-overflow.c
>>
>>
>> This test seems to fail on openSUSE 12.2 32bit because...
>>
>>>
>>> Added: cfe/trunk/test/CodeGen/compound-assign-overflow.c
>>> URL:
>>> http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGen/compound-assign-overflow.c?rev=171801&view=auto
>>>
>>> ==============================================================================
>>> --- cfe/trunk/test/CodeGen/compound-assign-overflow.c (added)
>>> +++ cfe/trunk/test/CodeGen/compound-assign-overflow.c Mon Jan  7 16:25:52
>>> 2013
>>> @@ -0,0 +1,36 @@
>>> +// Verify proper type emitted for compound assignments
>>> +// RUN: %clang_cc1 -triple x86_64-apple-darwin10 -emit-llvm -o - %s
>>> -fsanitize=signed-integer-overflow,unsigned-integer-overflow | FileCheck %s
>>
>>                                              ^^^^^^^^^^^^^^^^^^^^^^
>> We have an 64bit target here.
>>
>>
>>>
>>> +
>>> +#include <stdint.h>
>>
>>
>> This includes
>>
>> features.h which in turn includes gnu/stubs.h which says:
>>
>> #if defined __x86_64__ && defined __LP64__
>> # include <gnu/stubs-64.h>
>> #endif
>>
>> Since the target is 64bit it tries to include gnu/stubs-64.h but it doesn't
>> exist on 32bit host. Maybe XFAIL on 32bit?
>>
>> Regards.
>>
>>