[cfe-commits] r171783 - in /cfe/trunk: lib/Sema/SemaType.cpp test/SemaCXX/c99-variable-length-array-cxx11.cpp

[Douglas Gregor]

On Jan 7, 2013, at 2:38 PM, Richard Smith <richard at metafoo.co.uk> wrote:

> On Mon, Jan 7, 2013 at 12:03 PM, Douglas Gregor <dgregor at apple.com> wrote:
>> Author: dgregor
>> Date: Mon Jan  7 14:03:16 2013
>> New Revision: 171783
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=171783&view=rev
>> Log:
>> Use the C++11 POD definition in C++11 mode to determine whether one
>> can create a VLA of class type. Fixes <rdar://problem/12151822>.
>> 
>> Added:
>>    cfe/trunk/test/SemaCXX/c99-variable-length-array-cxx11.cpp
>> Modified:
>>    cfe/trunk/lib/Sema/SemaType.cpp
>> 
>> Modified: cfe/trunk/lib/Sema/SemaType.cpp
>> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaType.cpp?rev=171783&r1=171782&r2=171783&view=diff
>> ==============================================================================
>> --- cfe/trunk/lib/Sema/SemaType.cpp (original)
>> +++ cfe/trunk/lib/Sema/SemaType.cpp Mon Jan  7 14:03:16 2013
>> @@ -1269,6 +1269,12 @@
>>                                            S.LangOpts.GNUMode).isInvalid();
>> }
>> 
>> +/// \brief Determine whether the given type is a POD or standard-layout type,
>> +/// as appropriate for the C++ language options.
>> +static bool isPODType(QualType T, ASTContext &Context) {
>> +  return Context.getLangOpts().CPlusPlus11? T.isCXX11PODType(Context)
>> +                                          : T.isCXX98PODType(Context);
> 
> This looks equivalent to QualType::isPODType, which the code used to
> call. The added test appears to pass without this change.


Silliness corrected in r171817, thanks!

	- Doug