[cfe-commits] [PATCH] Use executable name from compilation database.

Manuel Klimek klimek at google.com
Sun Jan 6 22:41:18 PST 2013


  Just to document this here, we cannot do this for at least two reasons:
  1. as mentioned, the found builtin headers might be incorrect for the tool
  2. we might not have created the compilation database with clang as the compiler (gasp!) - in that case, we still need to find builtin headers

  But, this is another signal that for tools the current builtin-header-logic is too brittle (especially for developing tools).

  I'd like to re-iterate the idea of compiling in and overlaying the builtin headers, this time with two alternative tweaks that hopefully address Chandler's concerns:
  1. do normal builtin header lookup, but overlay builtin headers if we did not find them on  the disk
  2. (combinable with 1) if we produce a diagnostic that references a builtin header, which is in an overlay, create a temp directory, dump the builtin header there, and reference the actual file on disk.

  Thoughts?

http://llvm-reviews.chandlerc.com/D265



More information about the cfe-commits mailing list