[cfe-commits] [clang-tools-extra] r171593 - /clang-tools-extra/trunk/cpp11-migrate/LoopConvert/StmtAncestor.h

Chandler Carruth chandlerc at gmail.com
Fri Jan 4 19:56:48 PST 2013


Hey Galina,

This commit should have fixed the build for one of the clang bots:

http://lab.llvm.org:8011/builders/clang-x86_64-darwin11-self-mingw32/builds/8298

But the bot didn't trigger on this commit. It's now re-running, but due to
a different commit and without showing this commit as one of the candidate
changes:

http://lab.llvm.org:8011/builders/clang-x86_64-darwin11-self-mingw32/builds/8299


I assume the bot is just not configured to track the clang-tools-extra
repository's commits? If so, is that something you can fix?

Thanks!
-Chandler


On Fri, Jan 4, 2013 at 6:57 PM, Chandler Carruth <chandlerc at gmail.com>wrote:

> Author: chandlerc
> Date: Fri Jan  4 20:57:54 2013
> New Revision: 171593
>
> URL: http://llvm.org/viewvc/llvm-project?rev=171593&view=rev
> Log:
> Add a namespace qualifier to the befriending statement for
> RecusiveASTVisitor. With Clang and modern GCCs this was found through
> the injected class name of the base class but older GCCs don't properly
> implement the injected class name rules.
>
> Modified:
>     clang-tools-extra/trunk/cpp11-migrate/LoopConvert/StmtAncestor.h
>
> Modified: clang-tools-extra/trunk/cpp11-migrate/LoopConvert/StmtAncestor.h
> URL:
> http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/cpp11-migrate/LoopConvert/StmtAncestor.h?rev=171593&r1=171592&r2=171593&view=diff
>
> ==============================================================================
> --- clang-tools-extra/trunk/cpp11-migrate/LoopConvert/StmtAncestor.h
> (original)
> +++ clang-tools-extra/trunk/cpp11-migrate/LoopConvert/StmtAncestor.h Fri
> Jan  4 20:57:54 2013
> @@ -182,7 +182,7 @@
>      return Found;
>    }
>
> -  friend class RecursiveASTVisitor<DeclFinderASTVisitor>;
> +  friend class clang::RecursiveASTVisitor<DeclFinderASTVisitor>;
>
>  private:
>    std::string Name;
>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130104/220ba2b9/attachment.html>


More information about the cfe-commits mailing list