[cfe-commits] Fix compilation error with static constexpr member functions

Christopher Berner cberner at fb.com
Thu Jan 3 11:18:05 PST 2013


I've run into this bug (http://llvm.org/bugs/show_bug.cgi?id=13517), which seems to be related to the fixme in SemaType.cpp on line 2691.

I talked to Chandler Carruth, and he suggested that I look at Sema::MergeFunctionDecl. Moving all the logic there (like that fixme seems to imply) didn't seem to work, because then functions that have a single definition don't get const added to them.

Instead, I put logic there to remove the errant constness from static functions. I've attached a patch. Please let me know if you have any comments, as I've never contributed to the Clang codebase before.

Thanks!
Christopher Berner
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130103/2aaf13b9/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: clang.patch
Type: application/octet-stream
Size: 1811 bytes
Desc: clang.patch
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130103/2aaf13b9/attachment.obj>


More information about the cfe-commits mailing list