[cfe-commits] Patch for bug 14744

Krzysztof Parzyszek kparzysz at codeaurora.org
Tue Jan 1 14:54:35 PST 2013


On 1/1/2013 4:28 PM, Dmitri Gribenko wrote:
> On Wed, Jan 2, 2013 at 12:07 AM, Krzysztof Parzyszek
> <kparzysz at codeaurora.org> wrote:
>> I think I sent it to the wrong list the first time.
>> Could someone review and commit if ok?
>
> Is it possible to add a test for this?
>

Certainly.  Not sure if it's very meaningful though.  Let me know what 
you think.

-Krzysztof




-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, 
hosted by The Linux Foundation
-------------- next part --------------
From 5866d4ed06b195c975077cb0468717f89cc653c1 Mon Sep 17 00:00:00 2001
From: Krzysztof Parzyszek <kparzysz at codeaurora.org>
Date: Sat, 29 Dec 2012 13:52:39 -0600
Subject: [PATCH] Bug 14744: ICE when compiling any program for Hexagon

---
 lib/Basic/Targets.cpp               |    2 +-
 test/Frontend/hexagon-data-layout.c |    6 ++++++
 2 files changed, 7 insertions(+), 1 deletions(-)
 create mode 100644 test/Frontend/hexagon-data-layout.c

diff --git a/lib/Basic/Targets.cpp b/lib/Basic/Targets.cpp
index ea19b15..c109462 100644
--- a/lib/Basic/Targets.cpp
+++ b/lib/Basic/Targets.cpp
@@ -3500,7 +3500,7 @@ public:
   HexagonTargetInfo(const std::string& triple) : TargetInfo(triple)  {
     BigEndian = false;
     DescriptionString = ("e-p:32:32:32-"
-                         "i64:64:64-i32:32:32-i16:16:16-i1:32:32"
+                         "i64:64:64-i32:32:32-i16:16:16-i1:32:32-"
                          "f64:64:64-f32:32:32-a0:0-n32");
 
     // {} in inline assembly are packet specifiers, not assembly variant
diff --git a/test/Frontend/hexagon-data-layout.c b/test/Frontend/hexagon-data-layout.c
new file mode 100644
index 0000000..d3aa99a
--- /dev/null
+++ b/test/Frontend/hexagon-data-layout.c
@@ -0,0 +1,6 @@
+// RUN: %clang -c -target hexagon-unknown-unknown %s
+
+// Testcase for bug 14744.  Empty file is sufficient, since the problem
+// was a bad data layout string in the Hexagon target causing an ICE
+// when compiling any Hexagon program.
+
-- 
1.7.6.4



More information about the cfe-commits mailing list