[cfe-commits] Fix PR 11326: conflicting mabi between -mabi and -target options on ARM

[Weiming Zhao]

You're right. That line is unnecessary.

Originally, I planned to patch the triple. Then, I found that it was unnecessary because ARMABIInfo::computerInfo() will do that.
But I forgot the clean up the code.

Thanks for the reviewing.
Weiming

Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation


-----Original Message-----
From: Rafael Espíndola [mailto:rafael.espindola at gmail.com] 
Sent: Wednesday, December 26, 2012 8:09 PM
To: weimingz at codeaurora.org
Cc: cfe-commits at cs.uiuc.edu; Anton Korobeynikov
Subject: Re: [cfe-commits] Fix PR 11326: conflicting mabi between -mabi and -target options on ARM

On 26 December 2012 17:53, Weiming Zhao <weimingz at codeaurora.org> wrote:
> Hi Rafael,
>
> Thanks for the review.
> I'm attaching the patch which includes test case.

Thanks for adding a test for the warning. I think the patch still needs a codegen patch that checks that the value passed to -mabi is actually used.

On the implementation itself: Why do you need to patch the triple instead of just changing the code using it to give preference to Opts.ABI?

+      Opts.Triple = T.getTriple();

This just copies the triple back, no?

> Thanks,
> weiming

Cheers,
Rafael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-PR-11326-Lack-diagnosic-message-when-ABI-conflicts-o.patch
Type: application/octet-stream
Size: 4300 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20121227/17517911/attachment.obj>