[cfe-commits] r170636 - in /cfe/trunk: include/clang/AST/ASTImporter.h include/clang/Basic/Diagnostic.h include/clang/Basic/DiagnosticASTKinds.td lib/AST/ASTImporter.cpp lib/Basic/Diagnostic.cpp lib/Driver/Driver.cpp test/ASTMerge/Inputs/class1.cpp test/ASTMerge/Inputs/class2.cpp test/ASTMerge/class.cpp test/Misc/warning-flags.c

[Nick Lewycky]

Hi Richard, I'm afraid this patch regressed crash emission:

nlewycky at ducttape:~$
FORCE_CLANG_DIAGNOSTICS_CRASH=1 llvm/Debug+Asserts/bin/clang -fsyntax-only
a.c
clang version 3.3 (trunk 171019)
Target: x86_64-unknown-linux-gnu
Thread model: posix
nlewycky at ducttape:~$

If I revert your this patch, it looks right:

nlewycky at ducttape:~$
FORCE_CLANG_DIAGNOSTICS_CRASH=1 llvm/Debug+Asserts/bin/clang -fsyntax-only
a.c
clang version 3.3 (trunk 171019)
Target: x86_64-unknown-linux-gnu
Thread model: posix
clang: note: diagnostic msg: PLEASE submit a bug report to
http://llvm.org/bugs/ and include the crash backtrace, preprocessed source,
and associated run script.
clang: note: diagnostic msg:
********************

PLEASE ATTACH THE FOLLOWING FILES TO THE BUG REPORT:
Preprocessed source(s) and associated run script(s) are located at:
clang: note: diagnostic msg: /tmp/a-L9z2m9.c
clang: note: diagnostic msg: /tmp/a-L9z2m9.sh
clang: note: diagnostic msg:

********************
nlewycky at ducttape:~$

Please fix.

Nick

On 19 December 2012 18:22, Richard Smith <richard-llvm at metafoo.co.uk> wrote:

> note_drv_command_failed_diag_msg
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20121224/9bc99405/attachment.html>