[cfe-commits] [PATCH] Implement Attr dumping for -ast-dump

[Alexander Kornienko]

  > I added a test for clang::fallthrough as part of AttributedStmt. My goal with the tests was just to test each type of attribute argument
  > for code coverage, rather than exhaustive testing of all attributes. The other C++ attributes don't provide any more code coverage,
  > so I didn't add them.

  No, of course we don't have to test each single attribute here. But it would be nice to test dumping of different kinds of them. For example, you've already found out that clang::fallthrough is probably the only statement attribute for now. And I would also like to see one of declaration attributes using [[]] syntax, e.g. [[noreturn]]. I know that the implementation erases differences between GNU and C++11 syntax quite early, but it would still be a good thing to have a test for this.

  Apart from that, the patch looks good, but I think it needs to be reviewed by Doug as well.

http://llvm-reviews.chandlerc.com/D234