[cfe-commits] r170563 - /cfe/trunk/lib/AST/CommentParser.cpp

Douglas Gregor dgregor at apple.com
Thu Dec 20 07:27:31 PST 2012


On Dec 20, 2012, at 7:26 AM, Dmitri Gribenko <gribozavr at gmail.com> wrote:

> On Thu, Dec 20, 2012 at 5:25 PM, Douglas Gregor <dgregor at apple.com> wrote:
>> 
>> On Dec 19, 2012, at 9:17 AM, Dmitri Gribenko <gribozavr at gmail.com> wrote:
>> 
>>> Author: gribozavr
>>> Date: Wed Dec 19 11:17:09 2012
>>> New Revision: 170563
>>> 
>>> URL: http://llvm.org/viewvc/llvm-project?rev=170563&view=rev
>>> Log:
>>> Comment parsing: add a missing 'else'.  Found by inspection.
>>> 
>>> No testcase because we were just building an extra AST node and eventually
>>> throwing it away, so it did not affect correctness.
>> 
>> So, can we teach Clang to warn about this form of mistake?
> 
> I think we can.  I'll try writing something this weekend (if I have time).

Cool, thanks!

	- Doug



More information about the cfe-commits mailing list