[cfe-commits] [PATCH] OpenCL images as builtin types

[Anton Lokhmotov]

Hi Guy,

Good to see progress on this front!  As I understand, you resubmitted your
earlier patch [1], where you fixed most of the comments from Tanya, Richard
and myself.  However, you did not address my comments re the address spaces
of images (global) e.g.:

  case BuiltinType::OCLImage1d:
    const unsigned AddrSpace =
Context.getTargetAddressSpace(LangAS::opencl_global);
    return llvm::PointerType::get(llvm::StructType::create(
                           CGM.getLLVMContext(), "opencl.image1d_t"),
AddrSpace);
  ...

Also, what's your plan to dealing with the image access qualifiers:
read_only and write_only?

Cheers,
Anton.

[1] http://lists.cs.uiuc.edu/pipermail/cfe-dev/2012-November/025557.html
[2] http://lists.cs.uiuc.edu/pipermail/cfe-dev/2012-October/025337.html