[cfe-commits] r170125 - /cfe/trunk/lib/Basic/Targets.cpp

Eli Friedman eli.friedman at gmail.com
Tue Dec 18 17:30:59 PST 2012


On Thu, Dec 13, 2012 at 5:22 AM, Guy Benyei <guy.benyei at intel.com> wrote:
> Author: gbenyei
> Date: Thu Dec 13 07:22:48 2012
> New Revision: 170125
>
> URL: http://llvm.org/viewvc/llvm-project?rev=170125&view=rev
> Log:
> Remove little endian specification from SPIR data layout - SPIR doesn't define endiannes in the data layout.
>
> Modified:
>     cfe/trunk/lib/Basic/Targets.cpp
>
> Modified: cfe/trunk/lib/Basic/Targets.cpp
> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Basic/Targets.cpp?rev=170125&r1=170124&r2=170125&view=diff
> ==============================================================================
> --- cfe/trunk/lib/Basic/Targets.cpp (original)
> +++ cfe/trunk/lib/Basic/Targets.cpp Thu Dec 13 07:22:48 2012
> @@ -4486,7 +4486,7 @@
>        SizeType     = TargetInfo::UnsignedInt;
>        PtrDiffType = IntPtrType = TargetInfo::SignedInt;
>        DescriptionString
> -        = "e-p:32:32:32-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:64:64-"
> +        = "p:32:32:32-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:64:64-"
>            "f32:32:32-f64:64:64-v16:16:16-v24:32:32-v32:32:32-v48:64:64-"
>            "v64:64:64-v96:128:128-v128:128:128-v192:256:256-v256:256:256-"
>            "v512:512:512-v1024:1024:1024";
> @@ -4500,7 +4500,7 @@
>        SizeType     = TargetInfo::UnsignedLong;
>        PtrDiffType = IntPtrType = TargetInfo::SignedLong;
>        DescriptionString
> -        = "e-p:64:64:64-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:64:64-"
> +        = "p:64:64:64-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:64:64-"
>            "f32:32:32-f64:64:64-v16:16:16-v24:32:32-v32:32:32-v48:64:64-"
>            "v64:64:64-v96:128:128-v128:128:128-v192:256:256-v256:256:256-"
>            "v512:512:512-v1024:1024:1024";

This change doesn't actually help; the DataLayout will just assume
big-endian.  You probably shouldn't have a description string at all.

-Eli



More information about the cfe-commits mailing list