[cfe-commits] r170467 - in /cfe/trunk: lib/AST/DeclPrinter.cpp test/Index/comment-objc-decls.m test/Index/format-comment-cdecls.c test/Index/overriding-method-comments.mm tools/libclang/CIndex.cpp tools/libclang/CMakeLists.txt tools/libclang/CXComment.cpp tools/libclang/CXTranslationUnit.h tools/libclang/Makefile tools/libclang/SimpleFormatContext.h unittests/AST/DeclPrinterTest.cpp

[jahanian]

On Dec 18, 2012, at 3:23 PM, Dmitri Gribenko <gribozavr at gmail.com> wrote:

> Hi Fariborz,

Previous comments is in r170478.

> 
>> 
>> +  llvm::IntrusiveRefCntPtr<DiagnosticOptions> DiagOpts;
>> +  llvm::IntrusiveRefCntPtr<DiagnosticsEngine> Diagnostics;
>> +  FileManager Files;
>> +  SourceManager Sources;
> 
> We already have a SourceManager.  Why not reuse it?  (I'm just
> guessing -- maybe creating an in-memory file is permanent for the
> SourceManager?)

I am not sure. Others, Doug,  may want to comment.

- Thanks, Fariborz