[cfe-commits] [PATCH] Fix PR14514: Call destructor automatically after a throw

WenHan Gu (谷汶翰) wenhan.gu at mediatek.com
Mon Dec 17 17:53:38 PST 2012


OK, thanks.
Patch set 3 uploaded.

> -----Original Message-----
> From: John McCall [mailto:rjmccall at apple.com]
> Sent: Tuesday, December 18, 2012 9:20 AM
> To: WenHan Gu (谷汶翰)
> Cc: Eli Friedman; anton at korobeynikov.info; andersca at mac.com;
> cfe-commits at cs.uiuc.edu
> Subject: Re: [PATCH] Fix PR14514: Call destructor automatically after a throw
> 
> On Dec 17, 2012, at 5:17 PM, WenHan Gu (谷汶翰)
> <wenhan.gu at mediatek.com> wrote:
> > Actually, I have thought this assertion issue before modifying it.
> > However, I think, checking destruct-able in one callee is much simple and
> clear than checking it in *all* caller, right?
> >
> > If this has some design consideration, please let me know.
> 
> Pushing a cleanup affects the emission of code and should not be done when
> unnecessary.
> 
> John.

************* Email Confidentiality Notice ********************
The information contained in this e-mail message (including any 
attachments) may be confidential, proprietary, privileged, or otherwise
exempt from disclosure under applicable laws. It is intended to be 
conveyed only to the designated recipient(s). Any use, dissemination, 
distribution, printing, retaining or copying of this e-mail (including its 
attachments) by unintended recipient(s) is strictly prohibited and may 
be unlawful. If you are not an intended recipient of this e-mail, or believe 
that you have received this e-mail in error, please notify the sender 
immediately (by replying to this e-mail), delete any and all copies of 
this e-mail (including any attachments) from your system, and do not
disclose the content of this e-mail to any other person. Thank you!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: PR14514_r3.patch
Type: application/octet-stream
Size: 3628 bytes
Desc: PR14514_r3.patch
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20121218/74d83d70/attachment.obj>


More information about the cfe-commits mailing list