[cfe-commits] r169489 - in /cfe/trunk: lib/CodeGen/CGExpr.cpp lib/CodeGen/CGObjCRuntime.cpp lib/CodeGen/CGRecordLayout.h lib/CodeGen/CGRecordLayoutBuilder.cpp lib/CodeGen/CGValue.h test/CodeGen/2008-01-07-UnusualIntSize.c test/CodeGen/PR4611-bitfield-layout.c test/CodeGen/bitfield-2.c test/CodeGen/init.c test/CodeGen/packed-nest-unpacked.c test/CodeGen/pr2394.c test/CodeGenCXX/2009-12-23-MissingSext.cpp test/CodeGenCXX/bitfield.cpp test/CodeGenCXX/references.cpp test/CodeGenObjC/bitfield-access.m

[Dmitri Gribenko]

On Thu, Dec 6, 2012 at 11:19 PM, Dmitri Gribenko <gribozavr at gmail.com> wrote:
> On Thu, Dec 6, 2012 at 1:14 PM, Chandler Carruth <chandlerc at gmail.com> wrote:
>> Modified: cfe/trunk/lib/CodeGen/CGValue.h
>> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CGValue.h?rev=169489&r1=169488&r2=169489&view=diff
>> ==============================================================================
>> --- cfe/trunk/lib/CodeGen/CGValue.h (original)
>> +++ cfe/trunk/lib/CodeGen/CGValue.h Thu Dec  6 05:14:44 2012
>> @@ -28,7 +28,7 @@
>>  namespace clang {
>>  namespace CodeGen {
>>    class AggValueSlot;
>> -  class CGBitFieldInfo;
>> +  struct CGBitFieldInfo;
>>
>>  /// RValue - This trivial value class is used to represent the result of an
>>  /// expression that is evaluated.  It can be one of three things: either a
>> @@ -246,7 +246,7 @@
>>    }
>>
>>    // bitfield lvalue
>> -  llvm::Value *getBitFieldBaseAddr() const {
>> +  llvm::Value *getBitFieldAddr() const {
>>      assert(isBitField());
>>      return V;
>>    }
>> @@ -290,16 +290,16 @@
>>
>>    /// \brief Create a new object to represent a bit-field access.
>>    ///
>> -  /// \param BaseValue - The base address of the structure containing the
>> -  /// bit-field.
>> +  /// \param BaseValue - The base address of the bit-field sequence this
>> +  /// bit-field refers to.
>
> Should this be '\param Addr'?
>
>>    /// \param Info - The information describing how to perform the bit-field
>>    /// access.
>> -  static LValue MakeBitfield(llvm::Value *BaseValue,
>> +  static LValue MakeBitfield(llvm::Value *Addr,
>>                               const CGBitFieldInfo &Info,
>>                               QualType type, CharUnits Alignment) {

Ping.  There's no 'BaseValue' parameter anymore.

Dmitri

-- 
main(i,j){for(i=2;;i++){for(j=2;j<i;j++){if(!(i%j)){j=0;break;}}if
(j){printf("%d\n",i);}}} /*Dmitri Gribenko <gribozavr at gmail.com>*/