[cfe-commits] clang formatter patch to move and rename RewriterTestContext.h

[Manuel Klimek]

On Mon, Dec 17, 2012 at 7:21 AM, Daniel Jasper <djasper at google.com> wrote:

> I think the RewriterTestContext should remain in Tooling as it has nothing
> to do with formatting. I guess, we could make it a public header there
> (clang/Tooling). And it should remain being called RewriterTestContext.
>

I just looked at the implementation again, and I agree - if anybody has an
idea how to use things like createOnDiskFile in something that's not a
test, I'd be curious to learn about the use case.

Cheers,
/Manuel


> The ObjC change looks fine as a temporary fix. Especially the part in
> Format.cpp will undergo a rewrite anyway, hopefully this week. I will look
> into what else needs to change to support ObjC. At the very least, we
> probably shouldn't set CPlusPlus LangOpts for the Lexer..
>
>
>
> On Wed, Dec 12, 2012 at 8:50 PM, Sean Silva <silvas at purdue.edu> wrote:
>
>> On Wed, Dec 12, 2012 at 1:00 PM, jahanian <fjahanian at apple.com> wrote:
>> > ter. This patch is an attempt to have a header in Format directory
>> > that others can use. Any suggestion is welcome.
>>
>> +djasper
>>
>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20121217/20974e5a/attachment.html>