[cfe-commits] clang formatter patch to move and rename RewriterTestContext.h

Daniel Jasper djasper at google.com
Sun Dec 16 22:21:40 PST 2012


I think the RewriterTestContext should remain in Tooling as it has nothing
to do with formatting. I guess, we could make it a public header there
(clang/Tooling). And it should remain being called RewriterTestContext.

The ObjC change looks fine as a temporary fix. Especially the part in
Format.cpp will undergo a rewrite anyway, hopefully this week. I will look
into what else needs to change to support ObjC. At the very least, we
probably shouldn't set CPlusPlus LangOpts for the Lexer..



On Wed, Dec 12, 2012 at 8:50 PM, Sean Silva <silvas at purdue.edu> wrote:

> On Wed, Dec 12, 2012 at 1:00 PM, jahanian <fjahanian at apple.com> wrote:
> > ter. This patch is an attempt to have a header in Format directory
> > that others can use. Any suggestion is welcome.
>
> +djasper
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20121217/478f7e66/attachment.html>


More information about the cfe-commits mailing list